feat(model): split provider and model selection - #52
Closed
Mineru98 wants to merge 3 commits into
Closed
Conversation
The provider/model split adds a /provider command; registry_test's two full ordered-list assertions were not updated and failed. Add /provider between /config and /model. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The registry stores Path.expand'd skill paths (forward slashes, lowercased drive on Windows); the dedup/skill assertions compared against raw Path.join values and diverged on Windows. Wrap them in Path.expand like source_id. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mineru98
added a commit
to Mineru98/ourocode
that referenced
this pull request
Jul 21, 2026
The full-suite windows-ci needs code from sibling PRs (path/CRLF/port test fixes live in Ouro-labs#52/Ouro-labs#55), so it cannot pass on this branch alone. Keep it on the v0.1.15 integration branch, where the merged tree is green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mineru98
added a commit
that referenced
this pull request
Aug 7, 2026
…d+test - qa_frames.all_json/0 (#38): return binary via IO.iodata_to_binary/1 to match its @SPEC String.t() and Ourocode.Json.decode/1 (needs a binary). - registry_test (#52): add /provider to expected command lists (the provider/model split introduced /provider; test was not updated). - renderer_chrome (#44): group the two put_composer_text/6 clauses so --warnings-as-errors passes (put_highlighted_token moved after them). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing as already-absorbed. The content of this branch is already present in Verified by merging this branch into Reopen if you believe something here is genuinely missing from |
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Provider choice and model choice are currently blended together. That makes it hard for users to understand whether they are choosing a runtime account, a model family, or a specific model variant.
Proposed change
Acceptance criteria
Verification
git diff --checkmix format --check-formattedon changed Elixir filesmix test test/ourocode/model test/ourocode/provider/codex_client_test.exs test/ourocode/command/registry/builtin_test.exs test/ourocode/terminal/command_model_commands_test.exs test/ourocode/terminal/command_discovery_commands_test.exs test/ourocode/terminal/event_loop_command_dispatch_test.exs test/ourocode/terminal/model_status_test.exs test/ourocode/terminal/tui_chat_test.exs test/ourocode/terminal/tui_model_selection_test.exs test/ourocode/terminal/tui_state_test.exs test/ourocode/terminal/tui_submit_test.exs-> 94 passedCloses #47
Closes #51